Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459549 --- Comment #10 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-09-05 11:35:41 EDT --- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=808844 + rpmlint is silent for SRPM and for RPM. + source file md5 checksum from SRPM is a299829e6d05edeb21b2a3e5580eb8c2 python-ethtool-0.3.tar.bz2 + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package python-ethtool-0.3-2.fc10 => Provides: ethtool.so Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review