Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457277 --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-09-05 10:26:13 EDT --- OK, builds and installs fine now. rpmlint says: pentaho-reporting-flow-engine.src:87: W: libdir-macro-in-noarch-package %attr(-,root,root) %{_libdir}/gcj/%{name} which comes from rpmlint not parsing the conditional arch-ness of this package. pentaho-reporting-flow-engine-javadoc.x86_64: W: non-standard-group Development/Documentation which is OK because we don't care what goes in group. And: pentaho-reporting-flow-engine-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package pentaho-reporting-flow-engine. which could use a line wrap. I'll go ahead and apprrove this and you can tweak that description when you check in. * source files match upstream: 9ddd78ea9239cefbad21e81621bdc4f2c1f1a9a42a247d38100d49882d90d475 pentaho-reporting-flow-engine-0.9.3.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK (javadoc description needs a line wrap). * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. X rpmlint has one valid, but minor complaint. * final provides and requires are sane: pentaho-reporting-flow-engine-0.9.3-2.fc10.x86_64.rpm pentaho-reporting-flow-engine.jar.so()(64bit) pentaho-reporting-flow-engine = 0.9.3-2.fc10 pentaho-reporting-flow-engine(x86-64) = 0.9.3-2.fc10 = /bin/sh flute java java-gcj-compat >= 1.0.31 jcommon jcommon-serializer jpackage-utils libfonts >= 0.3.4 libformula >= 0.1.18 libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcj_bc.so.1()(64bit) liblayout >= 0.2.9 librepository >= 0.1.6 libz.so.1()(64bit) pentaho-libxml sac pentaho-reporting-flow-engine-javadoc-0.9.3-2.fc10.x86_64.rpm pentaho-reporting-flow-engine-javadoc = 0.9.3-2.fc10 pentaho-reporting-flow-engine-javadoc(x86-64) = 0.9.3-2.fc10 = jpackage-utils pentaho-reporting-flow-engine = 0.9.3-2.fc10 * %check is not present; no test suite. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (rebuild-gcj-db). * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * javadocs are under _javadocdir. * ant called properly. * gcj called properly. APPROVED, just line-wrap the javadoc description at your leisure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review