Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458446 --- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-09-04 12:03:17 EDT --- Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=806666 + rpmlint is silent for SRPM and for RPM. + source files match upstream url fb8ae4ab0cae0b57101f78b046b3927b HTML-FromText-2.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=13, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.21 cusr 0.02 csys = 0.26 CPU) + Package perl-HTML-FromText-2.05-2.fc10 => Provides: perl(HTML::FromText) = 2.05 Requires: /usr/bin/perl perl(Email::Find::addrspec) perl(Exporter::Lite) perl(HTML::Entities) perl(HTML::FromText) perl(Scalar::Util) perl(Text::Tabs) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review