Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461105 --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-09-04 07:05:58 EDT --- + is OK - is NEEDs WORK Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=806045 - rpmlint is silent for SRPM. But NOT for RPM. labrea.i386: W: non-conffile-in-etc /etc/labrea.conf ==> use following in SPEC %config(noreplace) %{_sysconfdir}/labrea.conf + source files match upstream. e76d506e82b60cc5477ccee1b3368cda labrea-2.5-stable-1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Don't forget to fix conffile rpmlint message before import. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review