[Bug 461105] Review Request: labrea - A sticky honeypot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461105


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx




--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx>  2008-09-04 05:49:59 EDT ---
suggestions->
    1)you should drop options to %configure
    2)make install should be
    make install DESTDIR=%{buildroot} INSTALL="install -p"
    3)Drop INSTALL file from %docs
    4)macro usage should be unique
    either use $RPM_BUILD_ROOT or %{buildroot}
    5)buildroot tag should be
    %{_tmppath}/%{name}-%{version}-%{release}-root

    Submit new SRPM after fixing above issues and bump release

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]