Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459881 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx --- Comment #3 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-09-02 21:34:06 EDT --- My comment about macro forms was intended to be interpreted generally; either use the macro forms everywhere possible, or don't use them at all. I'm guessing you want to just replace the two instances of "%{__install}" with "install". This builds fine; rpmlint only complains about the spaces/tabs thing which I ignore completely. The license seems incorrect. The LICENSE file contains a plain 3-clause BSD license, and none of the source code seems to contain licensing information (save setup.rb, which, like a configure script, is not included in (and thus does not alter the final license) of the resulting package. So I'd think you need License: BSD. This is confirmed by the upstream web site. In addition, the LICENSE file does not seem to be included in the final package. The current version seems to be 1.2.4. It seems to have been released soon after this package was posted for review. Would you like to update? There seems to be a test suite included. Unfortunately running it requires "mocha", whatever that is; it doesn't seem to be packaged in Fedora, so I guess the test suite is currently unrunnable. * source files match upstream: a0ad0e408a083d32627828e73131c2ca4f61c5eab0e35e44122cf1eab340b50d sqlite3-ruby-1.2.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named and is cleanly written. X package does not use macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field does not match the actual license. * license is open source-compatible. X license text is not included in package. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: rubygem(sqlite3-ruby) = 1.2.2 sqlite3_api.so()(64bit) rubygem-sqlite3-ruby = 1.2.2-2.fc10 rubygem-sqlite3-ruby(x86-64) = 1.2.2-2.fc10 = libruby.so.1.8()(64bit) libsqlite3.so.0()(64bit) ruby(abi) = 1.8 rubygems * %check is not present; included test suite cannot be run. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. * rubygem(%{gemname}) provided. * gems installed properly. * gems installed to proper directory. * gems, cache, and specifications files/directories owned properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review