Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460786 --- Comment #2 from Ian Weller <ianweller@xxxxxxxxx> 2008-09-01 11:49:46 EDT --- + = good, x = bad x source files match upstream: - I get different sums, see http://ianweller.fedorapeople.org/mediawiki-Cite.txt Let me know if you did it differently. + package meets naming and versioning guidelines. - The version is 0, though, that seems a bit... weird. But, upstream doesn't have a version. x specfile is properly named, is cleanly written and uses macros consistently. - s/$RPM_BUILD_ROOT/%{buildroot} - Might be a good idea to change the svnrev to without an r and use it in the comment that tells us how you created the tarball. + summary is OK. + description is OK. x dist tag is present. - Add %{?dist} to the end of the Release + build root is OK. + license field matches the actual license. + license is open source-compatible. x license text included in package. - Fetch a copy of the GPLv2 in text form and shove it in %doc. + latest version is being packaged. + BuildRequires are proper. + %clean is present. + package builds in mock (koji dist-f10 OK, task ID 798507) + package installs properly. + rpmlint is silent. + final provides and requires are sane + %check is not present; no test suite upstream. I'm not sure how you would go about testing this, anyway. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Fix above with 'x' for approval -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review