Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 Andrea Musuruane <musuruan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan@xxxxxxxxx --- Comment #8 from Andrea Musuruane <musuruan@xxxxxxxxx> 2008-09-01 06:22:07 EDT --- (In reply to comment #7) > # rpmlint -i dosemu-1.4.0-1868svn.src.rpm > dosemu.src:27: E: use-of-RPM_SOURCE_DIR > You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use > a directory for building, use $RPM_BUILD_ROOT instead. Use: [...] --with-fdtarball=%{SOURCE1} > dosemu.src:28: W: configure-without-libdir-spec > A configure script is run without specifying the libdir. configure options > must be augmented with something like --libdir=%{_libdir} whenever the script > supports it. Use the configure macro and do not call configure directly. %configure --with-fdtarball=%{_sourcedir}/dosemu-freedos-bin.tgz Read here for a description: http://docs.fedoraproject.org/developers-guide/ch-rpm-building.html > dosemu.src: E: no-cleaning-of-buildroot %install > You should clean $RPM_BUILD_ROOT in the %clean section and just after the > beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT". Just do what is written. Write "rm -rf $RPM_BUILD_ROOT" in the first line after the "%install" line. That is: %install rm -rf $RPM_BUILD_ROOT Moreover, just having a quick glance at your spec, I saw that: * RPM_OPT_FLAGS are not used. * changelog is not in a valid format: https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs BTW, changelog should refer to the RPM not the main software. There is already a file named ChangeLog for this. * ChangeLog* files are not packaged. * Other doc packages are not packages. For example Bugs. * %{_datadir}/doc/dosemu is not a valid doc directory. It must be %{_docdir}/%{name}-%{version}. %{_docdir} is a macro for %{_datadir}/doc. * %{_datadir}/dosemu is not a valid data directory. It must be %{_datadir}/%{name}-%{version}. * use of macros can be improved: https://fedoraproject.org/wiki/Packaging/Guidelines#Macros * desktop files for GUI programs are missing: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * These defines are not needed: %define name dosemu %define version 1.4.0 Just use: Name: dosemu Version: 1.4.0 You will automatically have macros for these. * release tag is not correct: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release * buildroot is not correct: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Many BuildRequires are missing. Please recheck them!!! I read in the INSTALL file: - development libraries: X and S-Lang are strongly recommended. For full-screen use with X.org 7 or newer you may also need the libXxf86vm development libraries. GPM, SDL (>= 1.2), SVGALIB (>= 1.9.21), ALSA libraries, and libsndfile can be used when available. * Since this is the first version of dosemu for Fedora, I think that %pre section is not needed. * Why are you packaging a development version? Even thought this is not forbidden, I think is should be motivated. Bye, Andrea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review