Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=428798 --- Comment #25 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-01 03:10:47 EDT --- Created an attachment (id=315456) --> (https://bugzilla.redhat.com/attachment.cgi?id=315456) start up log without vldocking Okay, now OmegaT builds correctly from FOSS sources correctly (in mock) Then for 1.7.3_03-3: * License - As far as I checked the source codes, License tag must be "GPLv2+". * Dependency - Currently omegat cannot be lauched (logs attached) At least "Requires: vldocking" is needed (note: this is not automatically added by rpmbuild) ! Unneeded directory ------------------------------------------------------------ mkdir -p $RPM_BUILD_ROOT/%{_iconsdir} ------------------------------------------------------------ - Perhaps currently %_iconsdir is not used for this package? * Macros - Use macros for standard directories ------------------------------------------------------------ cat > $RPM_BUILD_ROOT%{_bindir}/%{namer} <<EOF #!/bin/sh . /usr/share/java-utils/java-functions <================= java -jar %{_javadir}/OmegaT.jar $* EOF ------------------------------------------------------------ /usr/share must be %{_datadir} (when you use %{_datadir} in the spec file here, rpmbuild correctly expands the macro) * Desktop file - "X-Desktop-File-Install-Version" is automatically added by desktop-file-install command, so this is not needed (and on rawhide this is 0.15) * General rpmlint issue ------------------------------------------------------------ OmegaT.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/OmegaT-1.7.3_03/readme_hu.txt OmegaT.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/OmegaT-1.7.3_03/readme.txt OmegaT.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/OmegaT-1.7.3_03/readme_pt_BR.txt OmegaT.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/OmegaT-1.7.3_03/readme_sk.txt (and so many) OmegaT.noarch: W: class-path-in-manifest /usr/share/java/OmegaT-1.7.3_03.jar OmegaT.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 7) ------------------------------------------------------------ - Many document files have CRLF (windows-like) end-of-line encoding. Usually this can be fixed by dos2unix, or if you want to keep timestamps (I usually keep timestamps), ------------------------------------------------------------ for file in ...... do sed -i.bak -e 's|\r||' $file touch -r ${file}.bak $file rm -f ${file.bak} done ------------------------------------------------------------ should remove these warnings - I am not Java expert, however is manifest needed for OmageT jar file? - For cosmetic issue, please select "spaces" or "tabs" for indentation, not using both. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review