Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459455 --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> 2008-08-31 14:41:53 EDT --- Sorry for the delay here... OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d8ec5246602b8933839fa8ec0d37df05 fmit-0.97.7.tar.bz2 d8ec5246602b8933839fa8ec0d37df05 fmit-0.97.7.tar.bz2.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The files here are all LGPLv2+ and GPLv2+ (they all have the 'or later' clause). So, the entire package as a whole would be 'GPLv2+' I think. Do you agree? 2. You need a rm -rf $RPM_BUILD_ROOT at the top of your %install section. 3. Any reason you are shipping your own desktop file instead of using the one provided by upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review