Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ocaml-reins - Library of OCaml persistent data structures https://bugzilla.redhat.com/show_bug.cgi?id=460732 Summary: Review Request: ocaml-reins - Library of OCaml persistent data structures Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@xxxxxxxxxxxxxxxxx ReportedBy: rjones@xxxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, fedora-package-review@xxxxxxxxxx Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-reins.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-reins-0.1-0.1.a.fc10.src.rpm Description: Library of OCaml persistent data structures This is a very simple package -- just a library containing a very big collection of purely functional data structures. rpmlint has this to say about the package: ocaml-reins.src:89: W: rpm-buildroot-usage %build export OCAMLFIND_DESTDIR=$RPM_BUILD_ROOT%{_libdir}/ocaml $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. I can't see a way to build this package without setting OCAMLFIND_DESTDIR in the %build stage. The package seems to stash this somewhere, and just setting it later during %install doesn't work. I don't know what "short circuiting" is and whether it's a problem that we break it. ocaml-reins.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. This is a well-known problem with OCaml packages and can be ignored (for now). RPM are promising to add a feature which will allow us to build this as noarch, but it's not there yet. Files in the main package: /usr/lib/ocaml/reins /usr/lib/ocaml/reins/META /usr/lib/ocaml/reins/reins.cma /usr/lib/ocaml/reins/reins.cmi /usr/share/doc/ocaml-reins-0.1 /usr/share/doc/ocaml-reins-0.1/COPYING /usr/share/doc/ocaml-reins-0.1/LGPL-2.1 Requires: rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(VersionedDependencies) <= 3.0.3-1 ocaml(Big_int) = 992d682669507b99e689b5a2188c0b9a ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3 ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1 ocaml(Complex) = bb333e8e4cda78107ccf27048ca40492 ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4 ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4 ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d ocaml(Lazy) = 8a4b5e7f0bdc6316df9264fd73cde981 ocaml(List) = da1ce9168f0408ff26158af757456948 ocaml(Map) = dedde7683d54ae7db1eb97cc868dd047 ocaml(Nat) = 0ea20dd1cc4533fd519b5542a89feb87 ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printexc) = 82717999a586ede6925c0aa18d6562ac ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(Random) = 9936935480b36bcbc716ee513f37876c ocaml(Ratio) = 7067125cce206dd2bbe93918ba7bdfe9 ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28 ocaml(Unix) = 9a46a8db115947409e54686ada118599 ocaml(runtime) = 3.10.2 Provides: ocaml(Reins) = 80e0049b95f5867ce642993dddbe7e76 ocaml-reins = 0.1-0.1.a.fc10 ocaml-reins(x86-32) = 0.1-0.1.a.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review