Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459934 --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-08-29 22:14:24 EDT --- * source files match upstream: 85d78d6732102fc917e345308b5b38b190cd4cde662adc0bafb589970d45af8c DateTime-Format-Pg-0.16002.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(DateTime::Format::Pg) = 0.16002 perl-DateTime-Format-Pg = 0.16002-1.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(DateTime) >= 0.13 perl(DateTime::Duration) perl(DateTime::Format::Builder) >= 0.72 perl(DateTime::TimeZone) >= 0.06 perl(DateTime::TimeZone::Floating) perl(DateTime::TimeZone::UTC) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=17, Tests=124, 2 wallclock secs ( 0.04 usr 0.03 sys + 2.04 cusr 0.18 csys = 2.29 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review