Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460289 --- Comment #2 from Ismael Olea <ismael@xxxxxxxx> 2008-08-29 17:32:34 EDT --- (In reply to comment #1) > For 2.0.6e-1: > > * SourceURL > - Please write how you can download the tarball you use. > ! Well, usually SOURCEx must be given by full URL, however > for this package I cannot find the proper URL (php script perhaps > redirects to somewhere we cannot see...). So please write > how to get the source tarball. I've tried the url too but it's clear there is some magic in the website to not let that. > * The place of %description > - On the current spec file: > --------------------------------------------------------------- > %package javadoc > Summary: Javadocs for %{name} > Group: Documentation > %description javadoc <======= Description begins here !!! ======== OMG! fixed. > Requires: %{name} = %{version}-%{release} > Requires: jpackage-utils > This package contains the API documentation for %{name}. > > --------------------------------------------------------------- > The current place of %description hides Requires. Please > fix this. > > ? Symlinking > - Would you explain why you want to name the created jar file > as %{name}-%{version}.jar and to create a symlink, not just > naming the jar file itself as %{name}.jar? > ref: > https://fedoraproject.org/wiki/Packaging/Java#Jar_file_naming I try to mimmic the same practice than binary libraries (*.so). Seems reasonable for me and I don't see it's agains guidelines. > > ! Duplicate documents > - %doc License....pdf for -javadoc subpackage is redundant (and > usually removing these is recommended) as -javadoc subpackage always > Requires: main package (but please fix %description issue). fixed! http://olea.org/tmp/vldocking.spec http://olea.org/paquetes-rpm/fedora-9/vldocking-2.0.6e-2olea.src.rpm http://olea.org/paquetes-rpm/fedora-9/vldocking-2.0.6e-2olea.noarch.rpm http://olea.org/paquetes-rpm/fedora-9/vldocking-javadoc-2.0.6e-2olea.noarch.rpm I'm trying to sync to my website. I'm finding troubles with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review