Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460182 --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-08-29 04:28:44 EDT --- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=792541 + rpmlint is silent for SRPM but NOT for RPM. python-virtualenv.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/virtualenv.py 0644 + source files match upstream. 8931b66dbb799120583dd107aab2fa89 virtualenv-1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: 1) from http://fedoraproject.org/wiki/Packaging/Python/Eggs#Upstream_Eggs drop file /usr/lib/python2.5/site-packages/support-files/setuptools-0.6c8-py2.5.egg from installing by adding line to %files %exclude %{python_sitelib}/support-files 2) remove rpmlint warning using following command in %prep sed -i -e "s|#!/usr/bin/env python||" virtualenv.py 3) you really don't need "ls" in %build. Remove that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review