Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458024 Matt Domsch <matt_domsch@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Matt Domsch <matt_domsch@xxxxxxxx> 2008-08-26 11:19:07 EDT --- Srinivas and I have gone back and forth a few times privately, and he's getting the hang of it. :-) Trivial changes yet which can be made at checkin time. Note the preferred value of BuildRoot I use, and since you are using the standard %setup macro now, you don't need to pass it %{name}-%{version}. With these changes, I approve. -Matt --- sblim-sfcc.spec Tue Aug 19 09:50:30 2008 +++ /home/mdomsch/sblim-sfcc.spec Tue Aug 26 10:13:44 2008 @@ -4,7 +4,7 @@ # Package spec for sblim-sfcc # -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root +BuildRoot: %(mktemp -ud +%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) Summary: Small Footprint CIM Client Library Name: sblim-sfcc @@ -30,7 +30,7 @@ Small Footprint CIM Client Library Heade %prep -%setup -q %{name}-%{version} +%setup -q %build chmod a-x backend/cimxml/*.[ch] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review