Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=443675 --- Comment #7 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> 2008-08-25 15:45:56 EDT --- (In reply to comment #6) > * Please, provide full path to the source tarball. E.g. > Source: http://ftp.robert-scheck.de/linux/%{name}/%{name}-%{version}.tar.gz > instead of > Source: %{name}-%{version}.tar.gz Really? See comment #1 again and AFAIK nirik complained at others about such things. > * Please, add empty %build section to make rpmlint happy :) I will do so, yes. > * Use %{_initrddir} instead of %{_sysconfdir}/rc.d/init.d > BTW useful list of rpm-macros: > https://fedoraproject.org/wiki/Packaging/RPMMacros AFAIK %{_initrddir} is obsolete since RPM 4.5.90 and %{_initrdir} is only available since RPM 4.5.90 (or the other way round). To avoid nasty if/else hackings, I'm always and everywhere using the less macrofied way in that single case (yes, I've e.g. EPEL packages). > Other things seems sane. Consider applying changes according to these advices, > and I'll made formal review. Before putting a new package there, can we clarify the points above and have a short talk regarding comment #3? Current situation is, that the sip-redirect needs to have a writeable log file, which I only can get with touching, as a %config isn't the right deal and %ghost doesn't create the file. Am I missing something or do you have a better idea? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review