Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457279 --- Comment #7 from Rakesh Pandit <rakesh.pandit@xxxxxxxxx> 2008-08-23 16:08:30 EDT --- Review Point is I could not start server for me at least on my machine. The init.d script seems to be very bad: [rpmbuild@rocky cerebro]$ sudo /etc/init.d/cerebro start Starting Cerebro: [ OK ] [rpmbuild@rocky cerebro]$ cat: /sys/class/net/msh0/address: No such file or directory I tried with : [rpmbuild@rocky cerebro]$ cerebroui --help master True Error in sys.excepthook: TypeError: print_exc() takes at most 2 arguments (3 given) Original exception was: Traceback (most recent call last): File "/usr/bin/cerebroui", line 1038, in <module> gui = GUI() File "/usr/bin/cerebroui", line 291, in __init__ CerebroInterface.__init__(self, ATYPE) File "/usr/lib/python2.5/site-packages/cerebro/interface.py", line 58, in __init__ self.signup() File "/usr/lib/python2.5/site-packages/cerebro/interface.py", line 62, in signup iface = bus.get_object('org.laptop.cerebro', '/org/laptop/cerebro') File "/usr/lib/python2.5/site-packages/dbus/bus.py", line 244, in get_object follow_name_owner_changes=follow_name_owner_changes) File "/usr/lib/python2.5/site-packages/dbus/proxies.py", line 241, in __init__ self._named_service = conn.activate_name_owner(bus_name) File "/usr/lib/python2.5/site-packages/dbus/bus.py", line 183, in activate_name_owner self.start_service_by_name(bus_name) File "/usr/lib/python2.5/site-packages/dbus/bus.py", line 281, in start_service_by_name 'su', (bus_name, flags))) File "/usr/lib/python2.5/site-packages/dbus/connection.py", line 607, in call_blocking message, timeout) dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.laptop.cerebro was not provided by any .service files [rpmbuild@rocky cerebro]$ [rpmbuild@rocky cerebro]$ /etc/init.d/cerebro start touch: cannot touch `/var/lock/subsys/cerebro': Permission denied ] [rpmbuild@rocky cerebro]$ Error in sys.excepthook: TypeError: print_exc() takes at most 2 arguments (3 given) Original exception was: Traceback (most recent call last): File "/usr/sbin/cerebro", line 1077, in <module> if __name__ == "__main__": main() File "/usr/sbin/cerebro", line 1054, in main sys.stdout = open("/var/log/cerebro", 'a') IOError: [Errno 13] Permission denied: '/var/log/cerebro' Does not look sane!! Regarding 1) conf file i agree 2) keep it on by default will be okay. rpmlint(rp => rpmlint): [rpmbuild@rocky noarch]$ rp -i cerebro-2.9.8-1.fc9.noarch.rpm cerebro.noarch: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/cerebro.conf A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here *I agree with you here. It does not seem to be logical for putting a noreplace on it.* cerebro.noarch: W: service-default-enabled /etc/rc.d/init.d/cerebro The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. *you can ignore it* 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Build successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=781524 Required: [x] Name -- [!] License -- License seems to be GPLv2+ as I can check from COPYING & src [x] Spec file is in American Eng and legible [x] Build successfully [x] BuildRequires [x] Duplicate files - nil [NA] locale [x] permissions -- okay [x] source link correct [x] packaging guidlines [x] Buildroot correct [x] owns every directory it creates [x] file encoding - checked [x] package has no dependency on files in %doc [x] gui [x] No dependencies outside FHS guidelines [x] md5sum Source from site: 4402c421790fcb13a942f01815145413 Source from srpm: 4402c421790fcb13a942f01815145413 [x] np .pyc files in %{_bindir} [x] .egg taken care Optional suggestions: a. if you are still to report upstream about the missing shebang -- then may be you would like to inform. Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated In short: may be you need to work on making application get to usable level in sane way first, then there is license issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review