Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459858 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-08-23 10:56:45 EDT --- Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=781102 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1cfc4d7492b276aae3c5bb685182af75 ibus-table-0.1.1.20080823.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions:- you should correct license file COPYING to GPLv2 text. Use make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install to preserve timestamps. APPROVED. are you going to submit ibus-table-zhengma, ibus-table-wubi these packages also or will be adding in future releases? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review