Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455039 --- Comment #11 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2008-08-23 10:18:21 EDT --- Review: MUST Items: + rpmlint silent. + The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines . + The package licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The spec file written in American English. + The spec file for the package is legible. +/- The sources used to build the package were taken from svn. No official tarball. + The package successfully compiles and builds into binary rpms on at least one supported architecture (ppc). + All build dependencies are listed in BuildRequires. + A package must owns all directories that it creates. + A package does not contain any duplicate files in the %files listing. + Permissions on files are set properly. + The package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT. + The package consistently uses macros, as described in the macros section of Packaging Guidelines . + The package contains code, or permissable content. + All, the package includes as %doc, does not affect the runtime of the application. + The packages does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT. + All filenames in rpm packages are valid UTF-8. There is only one thing remain. Since we using a svn snapshot, we need to change versioning scheme. I advice you to change Release field to 0.4.%{svnrevision}%{?dist} - note leading zero. That allows us to upgrade package from our svn snapshot to official 1.0 tarball (when it will be out). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review