Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456953 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-08-20 16:03:58 EDT --- Now to remember all of that ocaml knowledge I've flushed over the past couple of months.... * source files match upstream: daa5dcb1344979b9e08ac33a61e28d8beb998bcddc247df67b6f3f8b7d7290a5 mikmatch-1.0.0.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane (listed in the original report). * %check is not present; no test suite upstream. I have no idea at all about testing this. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files (besides unnecessarily duplicated LICENSE file, not a blocker). * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * .cma, .cmi, .so, .so.owner, META files in the main package. * .a, .cmxa, .cmx and .mli files are in the -devel subpackage. * .cmo, .ml files not included * This is a parser extension, so .o files are OK in the main package. * .so files have no rpath APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review