Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455555 --- Comment #11 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-08-13 11:43:35 EDT --- For 0.10.13-2: * pkgconfig file issue - Leaving this line ------------------------------------------------------- Libs: -lhocr -lhspell -lz -ltiff -lm ------------------------------------------------------- in libhocr.pc means that libhocr-devel must have "Requires: hspell-devel zlib-devel libtiff-devel" (among these, zlib-devel is Required by gtk2-devel) ** Requires * For -gtk subpackage - %_bindir/hocr-gtk has: ------------------------------------------------------- 30 31 import gtk, gtk.glade ------------------------------------------------------- and this means that -gtk subpackage Requires pygtk2-libglade (note: pygtk2-libglade Requires pygtk2) - Also the my previous comment (In reply to comment #5) > * Requires for -gtk subpackage > * Please recheck the dependency for -gtk subpackage. > For example, /usr/bin/hocr-gtk contains > ---------------------------------------------------------------- > 28 import pygtk > 29 pygtk.require('2.0') > ---------------------------------------------------------------- > This means that libhocr-gtk must have "Requires: pygtk2". is for libhocr-gtk, not for libhocr-python. * Desktop issue - The Category "Application" is also deprecated and should be removed. - sane-pygtk.desktop contains: ------------------------------------------------------------------ Icon=xsane ------------------------------------------------------------------ However I can find the icon with the name "xsane.<suffix>" nowhere. (even in xsane rpm) * Directory ownership issue - The directory %_defaultdocdir/%name-%version is not owned by any packges. ! Some notes: - This is not a blocker issue, however would you try to remove "implicit declaration of function" warning (i.e. try to fix codes so that the build succeeds with ------------------------------------------------------------------ %build export CFLAGS="%optflags -Werror-implicit-function-declaration" %configure #--disable-static make # %{?_smp_mflags} ------------------------------------------------------------------ or ask the upstream developer to remove this warning? (please refer to: http://www.redhat.com/archives/fedora-devel-list/2008-March/msg02036.html ) Currently build fails with "-Werror-implicit-function-declaration" as http://koji.fedoraproject.org/koji/taskinfo?taskID=775601 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review