[Bug 458698] Review Request: libgdbus - D-Bus helper library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458698





--- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx>  2008-08-13 05:48:02 EDT ---
1) I think you should also keep timestamps using following command
    make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

2) I see there is no documentation/APIs for this library but there are some
example files in test directory. you should also add them to %doc of -devel
package. Don't include irrelevant files from test/* to %doc

3) Drop INSTALL from %doc as its really of no use.

BTW, Is this your first package submission?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]