Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456353 --- Comment #1 from Brian Pepple <bdpepple@xxxxxxxxx> 2008-08-10 19:03:01 EDT --- Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Valid license tag * Buildroot has all required elements * All paths begin with macros * Files have appropriate permissions and owners Bad: * Fails to build in Mock. Your missing a BuildRequires on expat-devel. * rpmlint produces the following: ffado.x86_64: W: no-documentation ffado.x86_64: E: arch-dependent-file-in-usr-share /usr/share/libffado/tests/test-dbus ffado.x86_64: E: arch-dependent-file-in-usr-share /usr/share/libffado/tests/test-isorecv-1 ffado.x86_64: E: arch-dependent-file-in-usr-share /usr/share/libffado/tests/test-isoxmit-1 ffado.x86_64: E: arch-dependent-file-in-usr-share /usr/share/libffado/tests/teststreaming3 ffado.x86_64: E: arch-dependent-file-in-usr-share /usr/share/libffado/tests/test-dbus-server ffado.x86_64: E: arch-dependent-file-in-usr-share /usr/share/libffado/tests/test-ffado libffado.x86_64: E: zero-length /usr/share/doc/libffado-2.0/NEWS libffado.x86_64: E: zero-length /usr/share/doc/libffado-2.0/TODO libffado.x86_64: W: no-soname /usr/lib64/libffado.so libffado-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 8 errors, 3 warnings. The documentation warning can be ignored, since you've got the relevant documention in the main package, though I would drop the NEWS & TODO files since they don't contain anything. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review