[Bug 458543] Review Request: eg - a wrapper for Git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458543





--- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2008-08-09 12:47:46 EDT ---
> eg.spec:61: E: use-of-RPM_SOURCE_DIR
> You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
> a directory for building, use $RPM_BUILD_ROOT instead.

It's kind of rare to see $RPM_SOURCE_DIR used like that; wouldn't it just be
easier to install %{SOURCE0} directly?

> As mentioned above, there are no other files in the source.  Is it normal to
> create something like 'README.Fedora' in this case?

You don't need to invent documentation where none exists.  You could, however,
consider writing a manpage and sending it upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]