Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458186 --- Comment #3 from Till Maas <opensource@xxxxxxxxx> 2008-08-09 07:18:59 EDT --- The patch probably needs to be send upstream and a comment about the status of the patch needs to be added to the spec: Patch0: gnusound-build.patch Reference: https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus Imho this should also apply to the .desktop file, therefore please send it to upstream, too. The %configure script already sets --prefix (you can test it with rpm --eval %configure), therefore I cannot see a reason, why this needs to be added: %configure --prefix=%{_usr} Btw. if you needed to add it, %{_prefix} would be probably a better choice. Is it intentional, that these files are not marked with %doc? %dir %{_docdir}/%{name}/html %{_docdir}/%{name}/html/*.html You do not yet need to rebuild it, I will try to do a complete review later, but I need to refresh my knowledge about some guidelines, first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review