Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458288 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-08-08 14:10:59 EDT --- For 0.2-4: ! EVR (epoch-version-release) - Would you tell me whether this tarball is the "pre-release" or "post-release" of the formal 0.2 version? * License - Currently I don't see any evicence that this package is licensed under GPLv2 only. Currently I regard this as licensed under GPL+ (I ignore debian/ directory) * SourceURL - As this uses git repository, please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control i.e. write as a comment how you created the tarball * Requires - Please make it sure that all rpms needed for this rpm are correctly listed in Requires. It seems at least "python-nose python-setuptools" is needed for Requires. * README.fedora - Please include this file as SOURCE and not create this file by using cat. Using cat changes the timestamp of this time every time you rebuild this srpm unneededly. * %clean * rm -f README.fedora is not needed. * scriptlets -------------------------------------------------------------- useradd -r -g gitosis -d /var/lib/gitosis -s /bin/sh \ -c "git repository hosting" gitosis -------------------------------------------------------------- - Is the directory %_localstatedir/lib/ unneeded (for %files entry)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review