Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448397 --- Comment #19 from Michal Marciniszyn <mmarcini@xxxxxxxxxx> 2008-08-08 10:37:24 EDT --- I looked at the package, everything seems ok, except that -devel package is not build (which was explained by pvrabec to be ok) and there is small error in the init script. There are followin tests in main run of initscript: [ -x $ntop ] || exit 1 [ -r "/etc/ntop.conf" ] || exit 1 [ -r "/var/lib/ntop/ntop_pw.db" ] || exit 1 that should be moved in the start function instead. Also error codes can be more precise, as 2nd and 3rd test failure indicates that the service is not configured. So, correct version is [ -x $ntop ] || exit 1 [ -r "/etc/ntop.conf" ] || exit 6 [ -r "/var/lib/ntop/ntop_pw.db" ] || exit 6 placed at the begining of start() function. Except for this small problem, the package is ready for fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review