Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457535 --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-08-05 00:36:37 EDT --- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756862 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 1cae8ab0ea5c5a369b73cb70a24fe9dd Myanmar3_Unicode.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + fc-cache scriptlets are used. * Regarding .conf file I don't see any problem as far as its following conf file writing guidelines from http://fedoraproject.org/wiki/SIGs/Fonts/Packaging/Fontconfig * Your SRPM is still old but you updated only SPEC. So before you import package make sure you use correct SRPM. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review