Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454462 --- Comment #15 from Thomas Moschny <thomas.moschny@xxxxxx> 2008-08-04 11:06:18 EDT --- There are some rpmlint issues: ksplice.src:93: E: files-attr-not-set ksplice.src: W: mixed-use-of-spaces-and-tabs (spaces: line 36, tab: line 1) ksplice.src: W: strange-permission fedora-ksplice-prepare 0775 Minor (non-blocking issues) regarding the fedora-ksplice-prepare script: - There are some typos: # fedora-ksplice-prepare fetches the source rpm of the currently installed kernel # from the repository an tries to prepare it for ksplice. ... echo "Kernel rpm will be prepared" - The tmpdir is not removed if something fails (use trap). - Not sure whether deleting the downloaded src.rpm is a good idea, the user might want to rerun the script if something breaks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review