Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457546 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-08-04 00:36:14 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756354 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f3b365136ccf88c79167ac3b1292e5b3 Net-RawIP-0.23.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=7, Tests=104, 4 wallclock secs ( 0.04 usr 0.01 sys + 4.38 cusr 0.08 csys = 4.51 CPU) + Package perl-Net-RawIP-0.23-1.fc10=> Provides: RawIP.so perl(Net::RawIP) = 0.23 perl(Net::RawIP::ethhdr) = 0.23 perl(Net::RawIP::generichdr) = 0.23 perl(Net::RawIP::icmphdr) = 0.23 perl(Net::RawIP::iphdr) = 0.23 perl(Net::RawIP::opt) = 0.23 perl(Net::RawIP::tcphdr) = 0.23 perl(Net::RawIP::udphdr) = 0.23 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libpcap.so.0.9 perl(AutoLoader) perl(Carp) perl(Class::Struct) perl(DynaLoader) perl(English) perl(Exporter) perl(Net::RawIP::ethhdr) perl(Net::RawIP::generichdr) perl(Net::RawIP::icmphdr) perl(Net::RawIP::iphdr) perl(Net::RawIP::opt) perl(Net::RawIP::tcphdr) perl(Net::RawIP::udphdr) perl(strict) perl(subs) perl(vars) perl(warnings) rtld(GNU_HASH) Suggestions:- You can include examples directory in %doc. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review