Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhocr - A Hebrew optical character recognition library https://bugzilla.redhat.com/show_bug.cgi?id=455555 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-08-01 12:08 EST ------- Well, for 0.10.13-1: * Explicit library dependency ----------------------------------------------------------- On main package: Requires: fftw, hspell On -gtk subpackage: Requires: gtk2 ----------------------------------------------------------- - Please explain why you want to write these explicit library related dependencies - Generally speaking, rpmbuild automatically detects library related dependencies and adds the dependency to binary rpms, so these explicit requires must be removed. However, if the rpm explicitly depends on the binaries in the required rpm, you can leave the explicit Requires (in that case, write as a comment why you want to leave the explicit requires) ** Requires * Requires for -devel subpackage * Every package which ships pkgconfig .pc files must have "Requires: pkgconfig" * Also please pkgconfig files themselfs to check dependencies for -devel subpackage A. %_libdir/pkgconfig/libhocr-gtk.pc contains: --------------------------------------------------------------- Requires: gtk+-2.0 --------------------------------------------------------------- This means that libhocr-devel subpackage must have "Requires: gtk2-devel" B. %_libdir/pkgconfig/libhocr.pc contains: --------------------------------------------------------------- Libs: -lhocr -lhspell -lz -ltiff -lm --------------------------------------------------------------- This means that libhocr-devel must have "Requires: hspell-devel zlib-devel libtiff-devel" (because of -lhspell -lz -ltiff) However all these 3 linkage seem unneeded, because none of the header files in libhocr-devel needs header files from fftw-devel, hspell-devel, libtiff-devel. I guess "@ld_hspell@ @ld_tiff@" in libhocr.pc.in should be removed. * Requires for -gtk subpackage * Please recheck the dependency for -gtk subpackage. For example, /usr/bin/hocr-gtk contains ---------------------------------------------------------------- 28 import pygtk 29 pygtk.require('2.0') ---------------------------------------------------------------- This means that libhocr-gtk must have "Requires: pygtk2". * Timestamps - To keep timestamps on installed files, please consider to use ---------------------------------------------------------------- make install \ INSTALL="install -p" \ DESTDIR=%{buildroot} \ ..... ----------------------------------------------------------------- This method usually works for based Makefiles based on recent autotools * Desktop files - Category "X-Fedora" is deprecated and should be removed. * %doc %_mandir - Files under %_mandir are automatically marked under %doc * Directory ownership issue - Please make it sure that all directories created when installing a rpm are correctly created by the rpm For example, %_datadir/hocr-gtk is not owned by any packages. Note: When you write: ----------------------------------------------------------------- %files %{_datadir}/hocr-gtk ----------------------------------------------------------------- This contains the directory %_datadir/hocr-gtk and all files/directories/etc under %{_datadir}/gtk, while when you write ----------------------------------------------------------------- %files %dir %{_datadir}/hocr-gtk ----------------------------------------------------------------- contains the directory %{_datadir}/hocr-gtk only. * %files entry on -python subpackage - On i386/ppc %{python_sitelib} and %{python_sitearch} are the same, so on these archs %files entries are duplicate as: ----------------------------------------------------------------- 1131 warning: File listed twice: /usr/lib/python2.5/site-packages/_hocr.so 1132 warning: File listed twice: /usr/lib/python2.5/site-packages/hocr.py 1133 warning: File listed twice: /usr/lib/python2.5/site-packages/hocr.pyc 1134 warning: File listed twice: /usr/lib/python2.5/site-packages/hocr.pyo ----------------------------------------------------------------- Writing %files entry a bit more verbosely can resolve this issue. * 64 bits issue - libhocr{-gtk}.pc.in contains: ----------------------------------------------------------------- 2 exec_prefix=${prefix} 3 libdir=${exec_prefix}/lib ----------------------------------------------------------------- So libdir is expanded as /usr/lib even on 64 bits archs, but this is wrong as on 64 bits archs libdir must be expanded as /usr/lib64. libdir=@libdir@ is correct. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review