Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: darkgarden-fonts - Dark Garden is a decorative outline font of unusual shape. https://bugzilla.redhat.com/show_bug.cgi?id=454967 ------- Additional Comments From lkundrak@xxxxx 2008-07-31 12:28 EST ------- 1.) This comment is useless: # for example: install -pm 644 *.ttf $RPM_BUILD_ROOT%{fontdir} 2.) You mix %{buildroot} and $RPM_BUILD_ROOT See http://fedoraproject.org/wiki/Packaging/Guidelines#UsingBuildRootOptFlags 3.) Use %setup macro instead of the following: %prep unzip %{SOURCE0} %build cd darkgarden-1.1 And after that is done, please do not move the files around in %build, there's no need to. 4.) Another useless comment, please remove it %changelog #DarkGarden * Mon Jul 21 2008 Lyos Gemini Norezel <Lyos.GeminiNorezel@xxxxxxxxx> 1.1-1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review