Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: html2text - HTML-to-text converter https://bugzilla.redhat.com/show_bug.cgi?id=457213 ------- Additional Comments From jeffperry_fedora@xxxxxxxxxxxxxx 2008-07-31 11:15 EST ------- Looks like your changes to the Makefile will add all DEBUG flags (in this case -g and -O2) so now you are always building a debug version. This debug version does, however, now include the $RPM_OPT_FLAGS I think you may want to separate these out in the Makefile. Leave your DEBUG variable, add support for turning it on and off. Add new variable (OPT_FLAGS?) to handle optmization related flags I'm kind of new at this package stuff though...so let's see what other feedback you get - there may be further conventions for handling this for Fedora packaging... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review