Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: html2text - HTML-to-text converter https://bugzilla.redhat.com/show_bug.cgi?id=457213 ------- Additional Comments From jeffperry_fedora@xxxxxxxxxxxxxx 2008-07-30 18:08 EST ------- ** UNOFFICIAL REVIEW - NEED SPONSOR *** INCOMPLETE BUT OK - rpmlint output not included for spec file My run shows it to be ok though: 0 packages and 1 specfiles checked; 0 errors, 0 warnings NEEDSWORK- rpmlint output not included for SRPM My run shows it to produce one warning. html2text.src: W: invalid-license GPL Review the short hand codes for licenses and choose the correct GPL version. See: http://fedoraproject.org/wiki/Licensing See: http://fedoraproject.org/wiki/Licensing#SoftwareLicenses In the case of html2text this field looks like it should say: GPL+ OK - The package must be named according to the Package Naming Guidelines OK - The .spec file name matches the base package %{name}, format: %{name}.spec OK - The package must be licensed with a Fedora approved license and meets the Licensing Guidelines OK - legal appears to be ok - GPL code according to README file. OK - The License field in the package spec file must match the actual license After the above rpmlint issue is cleared this will be OK OK - Source package includes license text in README, README is listed as doc file. OK - The spec file must be written in American English OK - The spec file for the package MUST be legible. OK - The sources used to build the package must match the upstream source md5sum is: 6097fe07b948e142315749e6620c9cfc NEEDSWORK - The package must successfully compile and build into binary rpms on at least one supported architecture. I was unable to get this to build. 1) Fetched spec file to rpmbuild/SPEC, 2) placed SRPM in rpmbuild/SRPM 3) extracted tar.gz source from SRPM and placed into rpmbuild/SOURCES 3) cd to rpmbuild/SPEC 4) rpmbuild -ba html2text.spec error: File .../rpmbuild/SOURCES/sgml.C.patch: No such file or directory This is probably a simple fix - I will leave this one as an exercise for the submitter. This is enough comment for now...possibly more to come. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review