Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: open-cobol - OpenCOBOL - COBOL compiler https://bugzilla.redhat.com/show_bug.cgi?id=457261 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dan@xxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From dan@xxxxxxxx 2008-07-30 14:19 EST ------- OK source files match upstream: 4c0930a74e92014317b2f237aaedc90acc2b72df open-cobol-1.0.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. BAD license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A* %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - you should specify License: GPLv2+ and LGPLv2+, because the library is LGPLed, or use additional License tag for libcob and libcob-devel packages - "-g" is filtered-out from the CFLAGS and this is the cause for incomplete debuginfo too - rpmlint complains open-cobol.src: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1) libcob.x86_64: W: spurious-executable-perm /usr/share/doc/libcob-1.0/COPYING.LIB open-cobol.x86_64: W: spurious-executable-perm /usr/share/doc/open-cobol-1.0/ChangeLog open-cobol.x86_64: W: spurious-executable-perm /usr/share/doc/open-cobol-1.0/COPYING open-cobol.x86_64: W: spurious-executable-perm /usr/share/doc/open-cobol-1.0/AUTHORS open-cobol.x86_64: W: spurious-executable-perm /usr/share/doc/open-cobol-1.0/THANKS open-cobol.x86_64: W: spurious-executable-perm /usr/share/doc/open-cobol-1.0/README open-cobol.x86_64: W: spurious-executable-perm /usr/share/doc/open-cobol-1.0/NEWS run chmod a-x on these files, the same action will be required for the sources (*.{c,h}) that will go into debuginfo sub-package open-cobol.x86_64: E: devel-dependency libcob-devel OK, explained in comment #2 - the package contains a test-suite - could it be run during the build? - running configure prints "configure: WARNING: Unrecognized options: --with-readline" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review