Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nxt_python - a package for controlling a LEGO NXT robot using python https://bugzilla.redhat.com/show_bug.cgi?id=454914 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-07-29 18:59 EST ------- Hum .. source0 seems plain wrong. Why not using the one from the project's site, http://home.comcast.net/~dplau/nxt_python/download/nxt_python-0.7.tar.gz ? Not to mention that the file bundled in the src.rpm is different than the one specified now in %source. python as a BR is redundant, python-devel will bring it in. Creating a specific group should follow the guidelines available at https://fedoraproject.org/wiki/Packaging/UsersAndGroups. Mind the "We never remove users or groups created by packages." line. rpmlint also complains about that (nxt_python.noarch: W: dangerous-command-in-%postun groupdel) Otherwise things seem pretty OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review