Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: figlet - a program to print stdin to stdout as ASCIIart https://bugzilla.redhat.com/show_bug.cgi?id=454917 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-07-29 18:36 EST ------- There are a couple of fixes needed: 1) According to the following section of the build log: + make -j5 gcc -g -DDEFAULTFONTDIR=\"/usr/share/figlet\" \ -DDEFAULTFONTFILE=\"standard.flf\" \ figlet.c zipio.c crc.c inflate.c -o figlet gcc -g -o chkfont chkfont.c chkfont.c: In function 'my_alloc': chkfont.c:68: warning: incompatible implicit declaration of built-in function 'malloc' chkfont.c: In function 'usageerr': chkfont.c:103: warning: incompatible implicit declaration of built-in function 'exit' chkfont.c: In function 'checkit': chkfont.c:226: warning: incompatible implicit declaration of built-in function 'exit' chkfont.c:260: warning: incompatible implicit declaration of built-in function 'free' chkfont.c: In function 'main': chkfont.c:458: warning: incompatible implicit declaration of built-in function 'free' chkfont.c:460: warning: incompatible implicit declaration of built-in function 'exit' the default compiler flags setup by the buildsystem are ignored. Please fix the spec to use them 2) INSTALL="install -p" is ignored. "make install" uses a plain cp (rather than $INSTALL) which does not preserve timestamps. Please try to fix that, too. 3) the changelog contains a reference to "%files". Please use "%%files" instead (this will make rpmlint happier) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review