Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: appliance-tools tools for generating appliance images on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=457152 ------- Additional Comments From dlutter@xxxxxxxxxx 2008-07-29 18:22 EST ------- OK - Package name N/A - License info is accurate Upstream does not include a separate license, though comments in the code indicate GPLv2 (would be good if upstream included a license; in that case, install it as %doc) OK - License tag is correct and licenses are approved N/A - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used N/A - Source md5sum matches upstream Upstream has not made an official release; it would be good if that happened. Barring that, there needs to be a comment before Source0 explaining how the tarball was generated OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent OK - rpmlint is silent OK - definition of python_sitelib OK - Generate and include *.py[co] in sitelib OK - Do not include *.py[oc] in /usr/{bin,sbin} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review