Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libatasmart - ATA S.M.A.R.T. Disk Health Monitoring Library https://bugzilla.redhat.com/show_bug.cgi?id=456723 adel.gadllah@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From adel.gadllah@xxxxxxxxx 2008-07-28 10:41 EST ------- (In reply to comment #3) > (In reply to comment #1) > > [-] source files match upstream: > > it doesn't fbffdc4551dd63368babf6fdd659a4bef8e0e647 vs > > 23116bb3a88fb9ccfbe229ac5a209beb8c80535f > > Fixed. Since I am both upstream and the packager I got a bit confused I guess. OK both are the same now (fbffdc4551dd63368babf6fdd659a4bef8e0e647). I know that you are upstream, hence the comment about bumping the version when generating new tarballs ;) > > [-] license field matches the actual license: > > The spec says "License: LGPLv2" while the source files say "or (at your > > option) any later version." > > Please change to LGPLv2+ > > Fixed. OK > (In reply to comment #2) > > One more thing pass %{?_smp_mflags} to the make command. > > Fixed. OK > I uploaded the spec file and the srpm to the same location. I didn't bump the > rpm revision. You should (even during the review process). As for the package now its fine. => APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review