Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 ------- Additional Comments From dan@xxxxxxxx 2008-07-28 04:49 EST ------- OK source files match upstream: ae804223c15ac2ed39988bd82bd0996bb8c566f2 oggvideotools-0.4.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. BAD BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - you should add BR: libogg-devel, libtheora-devel, SDL-devel or is this intentional ??? - see my comment #4 for the flags, correct debuginfo depends on them too - the Patch: tags are using tabs instead of spaces -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review