Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inadyn-mt - Dynamic DNS Client https://bugzilla.redhat.com/show_bug.cgi?id=441899 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-07-27 16:49 EST ------- ref #9: Bryan, you have included the file corresponding to GPL v3, but most of the source files claim GPLv2 or later. Since there are substantial differences between v2 and v3, could you please confirm that you really want the project to be released under GPLv3 ? Note that, according to http://fedoraproject.org/wiki/Licensing/FAQ, simply including the gpl.txt in the tarball is not enough. Quoting from that page: Q: How do I figure out what version of the GPL/LGPL my package is under? A: The short answer is to look at the source. Here is the long answer: COPYING does not signal licensing intent (it might not seem intuitive, but this is what Red Hat legal told us, and we're going by that). The order of operations goes like this: 1. What does the code say? If it specifies a version, that's what it is. Jochen: the src.rpm you have uploaded has MD5 errors. I have recreated the src.rpm using the new spec and the source downloaded from sf.net and everything seems mostly OK. Please find below the rpmlint rpmlint of the source RPM: inadyn-mt.src:21: W: unversioned-explicit-obsoletes inadyn inadyn-mt.src:22: W: unversioned-explicit-provides inadyn -> both are intended as such inadyn-mt.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4) -> cosmetic... rpmlint of inadyn-mt.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/inadyn-mt-2.12.22/COPYING -> classic case of cr/lf usage; anyway, what's the reason for modifying the filename from gpl.txt to COPYING? gpl.txt is just as valid. inadyn-mt.x86_64: E: non-readable /etc/inadyn.conf 0600 -> already discussed and acceptable inadyn-mt.x86_64: W: incoherent-init-script-name inadyn -> already discussed and acceptable Starting the program gives Starting inadyn: Sun Jul 27 23:45:13 2008: W:LANG: Cannot open language file. Will use english defaults, or default override (--lang_file <path/file_name>...) Is it intended ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review