Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=454208 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-27 11:13 EST ------- Well, for 0.2.2-4: * Patch name ------------------------------------------------------------- Patch0: %{name}-%{version}-warnings.patch ------------------------------------------------------------- - For the names of patches, you usually want not to use macros (especially %version). It often happens that you don't have to modify patches even if the tarball is upgraded. However if you use %{version} for patches' names, you have to recreate patches again even in such cases. * Modifying CFLAGS ------------------------------------------------------------- %configure CFLAGS="${RPM_OPT_FLAGS} -Werror-implicit-function-declaration" export CFLAGS make %{?_smp_mflags} ------------------------------------------------------------- - Well, inserting CFLAGS in this method actually does _not_ change CFLAGS (see the result: http://koji.fedoraproject.org/koji/taskinfo?taskID=741776 ) The correct way is either - to export CFLAGS _before_ %configure (also please check what %configure does by $ rpm --eval %configure). This method is preferred than the latter. Recent autotool based Makefiles/configures usually accepts this method. - to use make %{?_smp_mflags} CFLAGS=XXXXXXXXX This method should be used when the former method does not work. * %files entry A. ------------------------------------------------------------- %dir %{_datadir}/%{name}/ %{_datadir}/%{name}/ ------------------------------------------------------------- - The entry %{_datadir}/%{name}/ contains the directory %{_datadir}/%{name} itself, so the first line is not needed (and should be removed) B. ------------------------------------------------------------- %{_datadir}/icons/* %{_datadir}/icons/hicolor/*/apps/%{name}.svg ------------------------------------------------------------- - %{_datadir}/icons/* contains all directories under %{_datadir}/icons, for example /usr/share/icons/hicolor (please check the files entry by $rpm -ql florence). /usr/share/icons/hicolor and so on are already owned by hicolor-icon-theme and should not be owned by this package (the first line must be fixed) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review