Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inadyn-mt - Dynamic DNS Client https://bugzilla.redhat.com/show_bug.cgi?id=441899 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-07-26 20:15 EST ------- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: inadyn-mt.src:21: W: unversioned-explicit-obsoletes inadyn -> see issue 1 below inadyn-mt.src:22: W: unversioned-explicit-provides inadyn -> see issue 1 inadyn-mt.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4) -> cosmetic, please fix inadyn-mt.src: W: non-coherent-filename inydyn-mt-2.12.18-1.fc9.src.rpm inadyn-mt-2.12.18-1.fc9.src.rpm ->no idea what triggers this, I am going to ignore it binary RPM: inadyn-mt.x86_64: E: non-readable /etc/inadyn.conf 0600 -> no problem here, the file contains sensitive info inadyn-mt.x86_64: W: incoherent-init-script-name inadyn -> it is intended so it is acceptable, although I see no point in preserving the name of the other application [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2+ [!] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: a9c6c8cbb1c9f1ad7b2d928305972e2248784797 inadyn-mt.v.02.12.18.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!] The spec file handles locales properly. See issue 3 below [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [!] Latest version is NOT packaged. See issue 4 below [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 but see issue 5 below [?] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. I cannot test, I have no dyndns connections [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. === Issues === 1. I'd say that a versioned obsolete would be safer, but I'll trust your judgement, especially as inadyn seems to have disappeared (I cannot find anything useful at http://inadyn.ina-tech.net/ ) and inadyn-advanced had it's last version released in 2006 2. Please ping upstream to include the license in the package. Actually I could do it now ( :) ): Bryan, would you take care of that for the next release, please ? 3. There is no provision in the spec file for handling locales. Fortunately the source contains only one translation, English (lang/eng.lng). However I am not sure that %find_lang can handle the approach for locales used by this application. 4. Latest version is 2.12.20, the src.rpm contains 2.12.18. Not mandatory, but it would be nice to update your package, especially as the changelog mentions a fix about help usage. 5. Any particular reason to not use parallel make ? If yes, please comment it in the spec; otherwise please adjust the spec file === Final Notes === No real show stoppers but please take care of the above mentioned issues. Once you do that I'll be happy to approve your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review