Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=454208 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-26 14:19 EST ------- (In reply to comment #9) > (In reply to comment #8) > > - The other issue is > > ------------------------------------------------------------------- > > 259 keyboard.c:388: warning: implicit declaration of function > > 'layoutreader_readkeyboard' > > ------------------------------------------------------------------- > > Would you try to remove "implicit declaration of function' warning? > > c.f. > > https://www.redhat.com/archives/fedora-devel-list/2008-March/msg02036.html > > Sorry, but fixing code has to be done by UPSTREAM and not by the maintainer > which tries to get downstream hereby. It is a warning and fine. While "I said would you 'try'?", however I must note: GCC's 'warning' means 'serious bug' on many cases... Actually leaving the warnings of 'implicit declaration of function' sometimes causes segv on the application (and this happened on my package!!) and 'leave it to upstream, Fedora's maintainer won't fix it' can _never_ be Fedora's policy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review