Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: figlet - a program to print stdin to stdout as ASCIIart https://bugzilla.redhat.com/show_bug.cgi?id=454917 rakesh.pandit@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakesh.pandit@xxxxxxxxx ------- Additional Comments From rakesh.pandit@xxxxxxxxx 2008-07-26 10:13 EST ------- I am not a sponsor. These are few suggestions: 1. No need for buildRequires: autoconf, automake, libtool, glibc 2. Source Link (or package source) should be from project download resources: ftp://ftp.figlet.org/pub/figlet/program/unix/ seems to be right place. 3. For making Source URL you may use Adam Jackson's trick: %define figversion %( echo %{version} | sed 's/\\.//g' ) ftp://ftp.figlet.org/pub/figlet/program/unix/%{name}%{figversion}.tar.gz 4. package does not own %{_datadir}/figlet directory use %{_mandir}/man6/figlet.6* %{_datadir}/figlet -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review