Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=454208 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-25 14:50 EST ------- Well, * Scriptlets - Requires(preun): GConf is missing * %configure - --prefix=/usr is unneeded. Please check again what %configure does by $ rpm --eval %configure * Macros - Please use macros correctly ------------------------------------------------------------------- sed -i "s|@LAYOUTDIR@|/usr/share/florence|" ------------------------------------------------------------------- /usr/share must be %{_datadir} (rpm expands this correctly) * Directory ownership issue - This is not yet correctly fixed. For example the directory %{_datadir}/%{name}/ is not owned by any packages. * Some issues from build.log ------------------------------------------------------------------- 637 GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL is set, not installing schemas 638 ./../gconf-refresh 639 kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec] 640 Unable to send HUP signal to gconf daemon. 641 Configuration will not be updated until reboot. 642 Florence may not function correctly before reboot. ------------------------------------------------------------------- - Calling "kill -HUP gconfd" command during build is not preferable. As this "gconf-refresh" script is not useful for building this package, please replace this script with some other command e.g. writing the following at %prep: ------------------------------------------------------------------- rm -f gconf-refresh ln -sf /bin/true gconf-refresh ------------------------------------------------------------------- - The other issue is ------------------------------------------------------------------- 259 keyboard.c:388: warning: implicit declaration of function 'layoutreader_readkeyboard' ------------------------------------------------------------------- Would you try to remove "implicit declaration of function' warning? c.f. https://www.redhat.com/archives/fedora-devel-list/2008-March/msg02036.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review