Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iwl5000-firmware - Firmware for Intel® PRO/Wireless 5000 A/G/N network adaptors https://bugzilla.redhat.com/show_bug.cgi?id=455032 jwilson@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jwilson@xxxxxxxxxx ------- Additional Comments From jwilson@xxxxxxxxxx 2008-07-25 14:28 EST ------- No errors or warnings from rpmlint, so on to the spec file... Pretty simple package, don't think the letter in the version matters. Only real issue I see is that you're putting the docs into /lib/firmware, while I believe the preferred location would be %docdir, and the license doesn't prevent us from putting it there -- iirc, ivtv-firmware has this requirement, but no such thing for Intel wireless firmware (just look at your own iwl4965-firmware package. :) Basically, just %doc the license and readme (or provide reasons why it must be in /lib/firmware), and I'll approve the package. Heck, I even have hardware to test with now, once driver support gets into rawhide, which kyle claims he's going to do today... :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review