[Bug 456038] Review Request: DarkIce - Live Audio Streamer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: DarkIce - Live Audio Streamer


https://bugzilla.redhat.com/show_bug.cgi?id=456038





------- Additional Comments From timc@xxxxxxxxxxxx  2008-07-25 05:20 EST -------
Hi. This is just an informal review with some comments you might
find helpful.

  * The description line starting "DarkIce is a live ..." exceeds 79
    characters and wraps around on a standard terminal, you should
    break this up.

  * Your %changelog entry version is 0.19.1-1 but your package name
    and version is 0.19-1 - they should be consistent.

  * The "GPL" license is invalid it should be "GPLv2" or "GPLv2+" for
    example, see https://fedoraproject.org/wiki/Licensing.

  * The Group "Applications/Sound and Video" does not exist in the
    official list in /usr/share/doc/rpm-4.4.2.3/GROUPS (or equivalent
    rpm version) whereas it should be one from this list according
    to http://docs.fedoraproject.org/drafts/rpm-guide-en/ch13s02.html
    (section 13.2.2.7), although I don't know how current that is.

  * You should have a %config in front of %{_sysconfdir}/darkice.cfg
    as its a configuration file (then changes to it will be preserved
    across rpm upgrades).

  * The "Requires: libogg" and "Requires: libvorbis" lines are superfluous,
    you should let rpm find these lib dependencies on its own.

  * Consider using %{name}/%{version} in the Source0 line (since you have
    used them in the Patch0 line)?

  * You use $RPM_BUILD_ROOT in the %install block but %{buildroot} in the
    %clean block - choose one or the other and be consistent.

  * Provided configuration file is broken when program run as I got
    the following error:

      DarkIce: ConfigSection.cpp:117: format missing in section icecast-0 [0]

    It seems inconsistent with the man page which says "format" applies
    to [icecast2-x] sections not [icecast-x] sections.

  * Not sure you need an explicit BuildRequires line for "pkgconfig", nor
    libogg and libvorbis (as these are pre-requisites of the equivalent
    -devel packages anyway).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]