Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-mwlib - MediaWiki conversion library for Python https://bugzilla.redhat.com/show_bug.cgi?id=456042 rickyz@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From rickyz@xxxxxxx 2008-07-24 04:28 EST ------- Build cleanly in mock. * rpmlint clean * package meets naming guidelines * uses macros consistently * build root is ok X license isn't completely correct, mwlib/cdb.py was taken from the spambayes project, and should be under the Python license (include both in the license tag and add a comment explaining it) * Requires/BuildRequires are OK X The %check section currently doesn't run the tests. I don't see any docs on how to run them (and there's a chance that it might require py.test, which isn't in Fedora), so it might be best to kill the section entirely. * Installs/uninstalls fine * Permissions are fine APPROVED (just fix the above issues) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review