Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bcrypt - File encryption utility https://bugzilla.redhat.com/show_bug.cgi?id=456303 rakesh.pandit@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From rakesh.pandit@xxxxxxxxx 2008-07-24 00:06 EST ------- Package did not built for me -- BuildRequires needs zlib-devel I compiled it after adding Buildrequires and here is review: Required [x] rpmlint output [x] package naming [x] spec file name [x] packaging guidlines [x] license approved [x] license field in spec [x] license file [x] language used in spec file -- American English [x] spec file -- legible [!] Source0 link did not worked for me, though I know this link should work for all projects on sourceforge. I downloaded using http://bcrypt.sourceforge.net/bcrypt-1.1.tar.gz and assume you did the same. May you please confirm. md5sum upstream - 8ce2873836ccd433329c8df0e37e298c package source - 8ce2873836ccd433329c8df0e37e298c [!] package build in mock [!] BuildRequires -- zlib-devel missing [NA] locales [NA] shared library files [NA] relocatable [x] owns directory it creates in %{doc} [x] duplicate files not present [x] %clean & %install section contain rm -rf $RPM_BUILD_ROOT [x] permissible package content [x] file encoding - utf-8 [x] file permissions -- correct [NA] Header files and static libraries [x] package has no dependency on files in %doc [NA] GUI Optional [NA] Query upstream regarding license [NA] Translation for description and summary available [!] Package build in mock for all architectures -- failed but after putting in BuildRequires build correctly [NA] scripts used [x] No dependencies outside FHS guidelines [NA] subpackages [NA] .pc files Optional suggestions (you may not like to consider them): a. BuiltRoot tag %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) is preferred b. using macros consistently e.g URL can be http://%{name}.sourceforge.net/ Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review